Fix logger passing: MidiCIDevice constructor now accepts logger parameter #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eter - Update MidiCIDevice constructor to accept optional logger parameter - Update CIDeviceModel to hold and pass logger to MidiCIDevice - Update CIDeviceManager to create logger wrapper from CIToolRepository - Fixes message logging issue where logger was never set on device - Matches Kotlin implementation pattern for logger dependency injection Co-Authored-By: Atsushi Eno <atsushieno@gmail.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
⚙️ Control Options:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix logger passing: MidiCIDevice constructor now accepts logger parameter
Summary
This PR updates the C++ implementation to match the recent Kotlin changes where
MidiCIDevicetakes aLoggerparameter in its constructor andCIDeviceModelholds a logger instance and passes it to the device. This fixes the message logging issue that wasn't resolved in PR #26.Changes Made
LoggerFunctionparameterCIToolRepository::log()toLoggerFunctionformatTechnical Details
The changes follow the exact same dependency injection pattern as the Kotlin implementation:
CIToolRepository→CIDeviceManager→CIDeviceModel→MidiCIDeviceMessageDirectionenum ↔ boolean)Testing
Fixes
Resolves the message logging issue where the logger was never set on the
MidiCIDeviceinstance, ensuring that MIDI-CI message logging now works properly in the C++ implementation.Link to Devin run: https://app.devin.ai/sessions/fd2a127aeac346318eef888375b20e1c
Requested by: Atsushi Eno (atsushieno@gmail.com)