Fix MIDI 2.0 SysEx handling and add comprehensive test suite #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix Messenger::process_input() to handle both MIDI 1.0 (with F0 prefix) and MIDI 2.0 (without F0 prefix) sysex messages - Add offset-based array indexing to support both transport formats - Port comprehensive test suite from ktmidi-ci Kotlin tests to C++ Google Test framework - Add tests for CI Factory, MIDI CI Device, MIDI CI Converter, Property Facades, and Profile Facades - Add specific tests for MIDI 1.0 vs MIDI 2.0 message processing validation - Update CMakeLists.txt to include all new test files - Maintain backward compatibility with existing MIDI 1.0 libremidi::midi_in transport - All core functionality tests continue to pass without regressions Co-Authored-By: Atsushi Eno <atsushieno@gmail.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
⚙️ Control Options:
|
…rocess_input() - Remove incorrect offset workaround from Messenger::process_input() - Fix CIDeviceModel::process_ci_message() to not re-add F0/F7 prefixes - Transport-specific preprocessing in CIDeviceManager handles F0 stripping - Update tests to reflect correct message format expectations - Maintains comprehensive test coverage from ktmidi-ci port - All core MIDI 1.0/2.0 processing tests pass - No regressions in existing functionality Co-Authored-By: Atsushi Eno <atsushieno@gmail.com>
devin-ai-integration bot
added a commit
that referenced
this pull request
Jun 16, 2025
- Change MUID deserialization from << 7, << 14, << 21 to << 8, << 16, << 24 - Fix source_muid, dest_muid, target_muid, and max_sysex parsing - Maintain 7-bit shifts for non-MUID fields (channels, header_size) - Ensures 32-bit MUID values are properly reconstructed instead of packed 28-bit values - Addresses regression introduced in PR #22 Co-Authored-By: Atsushi Eno <atsushieno@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix MIDI 2.0 SysEx Handling and Add Comprehensive Test Suite
Problem
The
Messenger::process_input()method in PR #21 introduced a regression where it expected all MIDI-CI messages to start with theF0SysEx prefix. However, MIDI 2.0 Universal MIDI Packets (UMP) SysEx messages start directly with the Universal SysEx ID (0x7E) without theF0prefix, causing MIDI 2.0 input processing to fail.Solution
Messenger::process_input()to handle both MIDI 1.0 and MIDI 2.0 SysEx message formatsF0prefixlibremidi::midi_intransportF0prefix when receiving input from MIDI 1.0 sourcesTechnical Details
The fix introduces an
offsetvariable that detects the transport format:F0 7E ...(offset = 1)7E ...(offset = 0)All array access throughout the method now uses
data[index + offset]to correctly parse both formats.Comprehensive Test Suite
Ported extensive test coverage from the
ktmidi-ciKotlin module to prevent future regressions:New Test Files Added:
test_ci_factory.cpp- Discovery messages, profile configuration, MIDI CI 32-to-28 bit conversiontest_midi_ci_device_extended.cpp- Device initialization, connection establishment, MUID handlingtest_midi_ci_converter.cpp- String encoding/decoding to/from ASCII formattest_property_facades.cpp- Property exchange workflows and operationstest_profile_facades.cpp- Profile configuration and managementEnhanced Existing Tests:
test_messenger.cpp- Added specific tests for MIDI 1.0 vs MIDI 2.0 message processing validationTest Results
The 7 failing tests are pre-existing issues unrelated to this fix (property JSON serialization and device connection setup problems that existed before these changes).
Verification
Link to Devin run
https://app.devin.ai/sessions/2821c23715c043b8b7fa33f5da15b773
Requested by: Atsushi Eno (atsushieno@gmail.com)