Fix mutex deadlocks and port missing Kotlin classes to C++ #13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix mutex deadlocks and port missing Kotlin classes to C++
Summary
This PR addresses the code freeze issue in
MidiCIDevice::get_muid()and ports missing Kotlin classes from thektmidi-ciimplementation to bring the C++ MIDI-CI implementation to feature parity.Key Changes
Mutex Deadlock Fixes
std::mutexwithstd::recursive_mutexthroughout the codebase to prevent deadlocksPropertyManager.cppwherestd::lock_guard<std::mutex>was incorrectly used withstd::recursive_mutexvariablesMidiCIDevice,ClientConnection,Messenger,PropertyManager,ProfileManager, andPropertyChunkManagerPorted Missing Facade Classes
Supporting Infrastructure
Build System Updates
Technical Details
Architecture
midi_ci::core,midi_ci::profiles,midi_ci::properties)Thread Safety
std::recursive_mutexto prevent deadlocksTesting
std::lock_guard<std::mutex>usage in codebaseFiles Changed
Link to Devin run
https://app.devin.ai/sessions/8b258fe476e943b1b077b47f942bc717
Requested by
Atsushi Eno (atsushieno@gmail.com)
This implementation resolves the inappropriate mutex lock issue in
MidiCIDevice::get_muid()and brings the C++ implementation to full feature parity with the originalktmidi-ciKotlin codebase.