Fix ProfileFacadesTest failures by resolving connection storage and callback issues #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…allback issues - Fix connection storage type mismatch: change from uint8_t to uint32_t keys in MidiCIDevice - Fix address retrieval bug in CIRetrieval::get_addressing() (read from byte 1 instead of 4) - Connect device message callbacks to Messenger callback system in set_message_received_callback() - All ProfileFacadesTest cases now pass: configureProfiles, configureProfiles2, configureProfiles3 The root cause was that ProfileReply messages were being generated correctly but never reaching the test callbacks due to disconnected callback systems and type mismatches in the connection storage that prevented proper message routing between devices. Co-Authored-By: Atsushi Eno <atsushieno@gmail.com>
devin-ai-integration bot
added a commit
that referenced
this pull request
Jun 19, 2025
- Change uint8_t to uint32_t for MUID variables in CIDeviceModel::on_connections_changed() - Aligns with core MidiCIDevice interface changes that use uint32_t for MUIDs - Fixes Qt GUI Device combo box not populating after discovery The issue was that PR #61 changed the core device to use uint32_t for MUIDs, but the tooling layer was still using uint8_t vectors, causing a type mismatch that prevented connection synchronization between core and GUI layers. Co-Authored-By: Atsushi Eno <atsushieno@gmail.com>
atsushieno
added a commit
that referenced
this pull request
Jun 19, 2025
…n-list-regression Fix connection list regression from PR #61 MUID type change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix ProfileFacadesTest failures by resolving connection storage and callback issues
Summary
This PR fixes all ProfileFacadesTest failures in the C++ MIDI-CI library by resolving critical issues in the connection storage system and message callback mechanism that prevented profile discovery communication between devices.
Root Cause Analysis
The ProfileFacadesTest failures were caused by three interconnected issues:
Connection Storage Type Mismatch: The
MidiCIDeviceconnection storage methods useduint8_tkeys while callers passeduint32_tMUIDs, causing connections to be stored with truncated keys and never found during lookups.Address Retrieval Bug: The
CIRetrieval::get_addressing()method was reading the address from the wrong byte position (byte 4 instead of byte 1) during message deserialization.Disconnected Callback Systems: The device's
message_received_callback_was never registered with the Messenger's internal callback system, so ProfileReply messages were processed correctly but never reached test callbacks.Changes Made
1. Fixed Connection Storage Type Mismatch
MidiCIDevice::store_connection(),remove_connection(),get_connection()parameter types fromuint8_ttouint32_tget_connections()return type to usestd::unordered_map<uint32_t, ...>connections_container to useuint32_tkeys2. Fixed Address Retrieval Bug
CIRetrieval::get_addressing()to read from byte position 1 instead of 43. Connected Device Callbacks to Messenger
MidiCIDevice::set_message_received_callback()to automatically register the callback with the Messenger's callback systemTest Results
All ProfileFacadesTest cases now pass successfully:
Verification
The fix was verified by:
cmake --build build./build/tests/midicci-gtest --gtest_filter="ProfileFacadesTest.*"Technical Details
The message flow now works correctly:
Link to Devin run: https://app.devin.ai/sessions/b86cef761d4c40f985dafa7fa7ea6e4f
Requested by: Atsushi Eno (atsushieno@gmail.com)