Implement getProfileRepliesForInquiry() function #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Port logic from Kotlin implementation to handle profile inquiry responses: - Handle ADDRESS_FUNCTION_BLOCK by getting all distinct profile addresses - Use ProfileHostFacade to access ObservableProfileList - Get enabled/disabled profiles for each address using get_matching_profiles() - Create ProfileReply messages with proper Common header This replaces the previous stub implementation that returned empty profile lists. Co-Authored-By: Atsushi Eno <atsushieno@gmail.com>
- Add MidiCIProfileDetails struct for profile-specific data - Implement get_profile_details() method to retrieve profile data by profile and target - Implement update_profile_target() method using existing ObservableProfileList::update - Add callback system with add_on_profile_set_callback() for profile state changes - Implement get_profile_details_entries() accessors for managing profile details - Update enable/disable methods to trigger callbacks matching Kotlin behavior This completes feature parity between C++ and Kotlin ProfileHostFacade implementations. Co-Authored-By: Atsushi Eno <atsushieno@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement getProfileRepliesForInquiry() function
This PR implements the
Messenger::getProfileRepliesForInquiry()function in C++ by porting the functionality from the Kotlin implementation in the ktmidi project.Changes Made
MIDI_CI_ADDRESS_FUNCTION_BLOCKspecially by getting all distinct addresses from profilesget_matching_profiles()<set>to support unique address collectionImplementation Details
The function now:
get_matching_profiles(address, enabled)This matches the Kotlin implementation logic:
getAllAddresses()in KotlinlocalProfiles.getMatchingProfiles()through C++ ProfileHostFacadeTesting
Link to Devin run
https://app.devin.ai/sessions/077230b20bad457b81fa82b2a5f8889e
Requested by: Atsushi Eno (atsushieno@gmail.com)