chore(ci): move integration tests to GitHub Actions #485
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simar7
reviewed
May 4, 2020
| case tc.expectedError != "": | ||
| require.NotNil(t, err) | ||
| assert.Contains(t, err.Error(), tc.expectedError, tc.name) | ||
| return |
Collaborator
Author
There was a problem hiding this comment.
Yes, in this case, an error is expected. It means we don't have to compare want and got. The original code is the following.
switch {
case tc.expectedError != "":
require.NotNil(t, err)
assert.Contains(t, err.Error(), tc.expectedError, tc.name
default:
...
}
if !tc.invalidImage {
// compare want and got
...
}
So, I've changed it to the following
switch {
case tc.expectedError != "":
require.NotNil(t, err)
assert.Contains(t, err.Error(), tc.expectedError, tc.name
return
default:
...
}
// compare want and got
compare()
I prefer a shallow nest.
simar7
approved these changes
May 4, 2020
masahiro331
pushed a commit
to masahiro331/trivy
that referenced
this pull request
May 26, 2020
* fix(standalone): add defer to close databases * test(client/server): launch a server only once * test(docker_engine): remove the duplicated case * test(docker_engine): copy a database only once * test(standalone): copy a database only once * test(server): fix tests according to updated mock * chore(mod): update * chore(ci): add integration tests to GitHub Actions * chore(ci): bump up Go to 1.14 * chore(ci): remove integration tests from CircleCI * chore(ci): add name * chore(ci): add new lines
GuaoGuao
pushed a commit
to GuaoGuao/trivy
that referenced
this pull request
Jun 24, 2020
* fix(standalone): add defer to close databases * test(client/server): launch a server only once * test(docker_engine): remove the duplicated case * test(docker_engine): copy a database only once * test(standalone): copy a database only once * test(server): fix tests according to updated mock * chore(mod): update * chore(ci): add integration tests to GitHub Actions * chore(ci): bump up Go to 1.14 * chore(ci): remove integration tests from CircleCI * chore(ci): add name * chore(ci): add new lines
liamg
pushed a commit
that referenced
this pull request
Jun 7, 2022
* fix(standalone): add defer to close databases * test(client/server): launch a server only once * test(docker_engine): remove the duplicated case * test(docker_engine): copy a database only once * test(standalone): copy a database only once * test(server): fix tests according to updated mock * chore(mod): update * chore(ci): add integration tests to GitHub Actions * chore(ci): bump up Go to 1.14 * chore(ci): remove integration tests from CircleCI * chore(ci): add name * chore(ci): add new lines
liamg
pushed a commit
that referenced
this pull request
Jun 7, 2022
liamg
pushed a commit
that referenced
this pull request
Jun 7, 2022
josedonizetti
pushed a commit
to josedonizetti/trivy
that referenced
this pull request
Jun 24, 2022
…init' (aquasecurity#485) Signed-off-by: Liam Galvin <liam.galvin@aquasec.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
gunzipDBcopies a database file to the temporal directory every time. It consumes a lot of disk spaces even if the file is removed bydefer os.RemoveAll(cacheDir). This is because the test process is still running, so the removed file can't be seen, but exists until the test process finishes.ref. https://access.redhat.com/solutions/2316
After all, it reaches the capacity of disk and returns the error "no space left on device". This PR changed tests so that the database file can be copied only once.
Blocker
go get -uafter feat(cache): add close function fanal#104 is merged