[move] Upgrade to newest state of Move step #2 #2032
Conversation
8110d62 to
5692f8e
Compare
zekun000
left a comment
There was a problem hiding this comment.
this is insane amount of work, only one thing I want to clarify before approve.
how do the new generated_txn_builder generated? do we manually copy the generated files from the target dir or?
The transaction generator doesn't work any longer. At least it didn't when I tried at the beginning of the refactoring. For now its a copy of the generated code before this change, then updated by hand to new naming. We need to fix the builder but not as part of this PR. |
| currency_code_required: bool, | ||
| ) { | ||
| SystemAddresses::assert_aptos_framework(account); | ||
| assert!(signer::address_of(account) == @aptos_framework, errors::requires_address(ENOT_APTOS_FRAMEWORK)); |
There was a problem hiding this comment.
Why not use system_addresses:: assert_aptos_framework ?
There was a problem hiding this comment.
Merge conflict resolution problem ... Resolved
|
someone probably needs to prioritize fixing the transaction generator, otherwise whoever update the script functions needs to manually update |
0ad2a8e to
13e3145
Compare
Yes, I'll look. But likely we can live also until GTM with hand editing. @davidiw wants to get completely rid of the generator. |
703393f to
e21788e
Compare
d665dfb to
85ebdea
Compare
❌ Forge test failureForge is land-blocking |
| for (k, v) in script_registry.iter() { | ||
| eprintln!("reg {}: {:?}", k, v); | ||
| } |
There was a problem hiding this comment.
Yeah, that code is not longer called, but better to remove this. Done.
❌ Forge test failureForge is land-blocking |
❌ Forge test failureForge is land-blocking |
d183b8e to
b1694dd
Compare
✅ Forge test successForge is land-blocking |
Description
Upgrades our repo to the new Move conventions of lower-case module names.
Test Plan
Existing tests.
This change is