这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@igor-aptos
Copy link
Contributor

@igor-aptos igor-aptos commented Nov 12, 2025

Description

How Has This Been Tested?

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Note

Adds LayoutReference abstraction and migrates pre_cancellation_tracker and bulk_order_book to use it, updating constructors, accessors, and destruction paths.

  • Aptos Stdlib:
    • New aptos_framework::layout_reference: Introduces LayoutReference<T> (Inline | ExternalTable) with new_external_table, borrow, borrow_mut, destroy, and move helpers.
  • Trading:
    • Market (market_types.move):
      • Replace Table<u8, PreCancellationTracker> with LayoutReference<PreCancellationTracker>.
      • Update new_market to layout_reference::new_external_table(...), get_pre_cancellation_tracker_mut to borrow_mut(), and cleanup via destroy().
    • Order Book (order_book.move):
      • Replace BulkOrderBook<M> with LayoutReference<BulkOrderBook<M>>.
      • Construct via layout_reference::new_external_table(...), access via borrow()/borrow_mut(), destroy via destroy().

Written by Cursor Bugbot for commit 486882b. This will update automatically on new commits. Configure here.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the final PR Bugbot will review for you during this billing cycle

Your free Bugbot reviews will reset on December 7

Details

Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

@igor-aptos igor-aptos force-pushed the igor/layout_reference branch from 646163d to 486882b Compare November 12, 2025 20:40
Base automatically changed from igor/remove_fill_id to main November 13, 2025 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants