[qs] Support V2 SignedBatchInfo and ProofOfStore messages with BlockInfoExt #18085
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 11, 2025
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Nov 11, 2025
4e6435b to
e1a91cd
Compare
d3049aa to
52f3018
Compare
e1a91cd to
c07419d
Compare
52f3018 to
251c641
Compare
c07419d to
eec8298
Compare
251c641 to
a094eaf
Compare
eec8298 to
ea4f27e
Compare
a094eaf to
f2dbced
Compare
f2dbced to
9244123
Compare
JoshLind
approved these changes
Nov 14, 2025
Contributor
JoshLind
left a comment
There was a problem hiding this comment.
Looks reasonable to me 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces
SignedBatchInfoMsgV2andProofOfStoreMsgV2consensus messages that sendSignedBatchInfo<BatchInfoExt>andProofOfStore<BatchInfoExt>respectively. The actual sending of these messages is implemented behind a feature flag.When enabled, Validators derive
BatchInfoExt::V2from the received batches and populating theBatchKindfield based on whether the batch contains any encrypted transactions. Validators make a local decision on the batch kind field and sign their batch infos. The proofs are derived from these new signed batch info message types.The downside is that given a Batch one need to scan transactions to check if they have encrypted transactions. This can be cached locally to save on rescans, but it has not been implemented in this PR.