这是indexloc提供的服务，不要输入任何密码
Skip to content

[Mempool] Add metrics & logs for broadcast behaviour. #17124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: aptos-release-v1.32
Choose a base branch
from
Open

[Mempool] Add metrics & logs for broadcast behaviour. #17124

wants to merge 1 commit into from
+49 −12

Conversation

JoshLind
Copy link
Contributor

Description

How Has This Been Tested?

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

@JoshLind JoshLind requested a review from bchocho as a code owner July 22, 2025 17:15
@JoshLind JoshLind added the CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR label Jul 22, 2025
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link
Contributor

✅ Forge suite compat success on 612b35b5cb3ff15d6c6a0e5db8764c559a0f6f70 ==> 399e319698c951c247df7c22ad7b4d1d029fceb7

Compatibility test results for 612b35b5cb3ff15d6c6a0e5db8764c559a0f6f70 ==> 399e319698c951c247df7c22ad7b4d1d029fceb7 (PR)
1. Check liveness of validators at old version: 612b35b5cb3ff15d6c6a0e5db8764c559a0f6f70
compatibility::simple-validator-upgrade::liveness-check : committed: 10220.47 txn/s, latency: 3309.65 ms, (p50: 3600 ms, p70: 3700, p90: 3900 ms, p99: 4100 ms), latency samples: 336640
2. Upgrading first Validator to new version: 399e319698c951c247df7c22ad7b4d1d029fceb7
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 2821.66 txn/s, latency: 11788.74 ms, (p50: 13500 ms, p70: 13600, p90: 13800 ms, p99: 14000 ms), latency samples: 105800
3. Upgrading rest of first batch to new version: 399e319698c951c247df7c22ad7b4d1d029fceb7
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 2764.74 txn/s, latency: 12021.69 ms, (p50: 13600 ms, p70: 13900, p90: 14200 ms, p99: 14300 ms), latency samples: 103500
4. upgrading second batch to new version: 399e319698c951c247df7c22ad7b4d1d029fceb7
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 5168.92 txn/s, latency: 6679.66 ms, (p50: 7200 ms, p70: 7500, p90: 7800 ms, p99: 7900 ms), latency samples: 179220
5. check swarm health
Compatibility test for 612b35b5cb3ff15d6c6a0e5db8764c559a0f6f70 ==> 399e319698c951c247df7c22ad7b4d1d029fceb7 passed
Test Ok

@github-actions GitHub Actions
Copy link
Contributor

✅ Forge suite realistic_env_max_load success on 399e319698c951c247df7c22ad7b4d1d029fceb7

two traffics test: inner traffic : committed: 13329.89 txn/s, submitted: 13330.68 txn/s, expired: 0.79 txn/s, latency: 2974.66 ms, (p50: 3000 ms, p70: 3000, p90: 3300 ms, p99: 4500 ms), latency samples: 5068380
two traffics test : committed: 99.99 txn/s, latency: 1383.61 ms, (p50: 1200 ms, p70: 1500, p90: 2100 ms, p99: 3100 ms), latency samples: 1820
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 2.034, avg: 1.748", "ConsensusProposalToOrdered: max: 0.174, avg: 0.171", "ConsensusOrderedToCommit: max: 0.508, avg: 0.432", "ConsensusProposalToCommit: max: 0.679, avg: 0.602"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.70s no progress at version 812864 (avg 0.12s) [limit 15].
Max epoch-change gap was: 1 rounds at version 4880735 (avg 0.50) [limit 4], 1.60s no progress at version 4880735 (avg 1.04s) [limit 16].
Test Ok

@trunk-io Trunk.io
Copy link

trunk-io bot commented Jul 22, 2025

Static Badge   Static Badge   Static Badge   Static Badge

Failed Test Failure Summary Logs
dkg::real_dkg::rounding::tests::test_rounding_small_stakes The test failed because total_weight was less than the expected minimum value. Logs ↗︎

View Full Report ↗︎ ⋅ Docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bchocho bchocho Awaiting requested review from bchocho bchocho is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@JoshLind