fix: optimize LRU cache #985
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| NSString *reason = [NSString stringWithFormat:@"The element identified by \"%@\" is either not present or it has expired from the internal cache. Try to find it again", uuid]; | ||
| @throw [NSException exceptionWithName:FBStaleElementException reason:reason userInfo:@{}]; | ||
| } | ||
| if (checkStaleness) { |
There was a problem hiding this comment.
would it be possible to add an integration test to validate this behaviour?
Author
There was a problem hiding this comment.
can we pick this up later? is it a release blocker? to how much extent do we cover this in tests currently?
There was a problem hiding this comment.
yes, it is ok to do it in a different PR
KazuCocoa
reviewed
Feb 28, 2025
mykola-mokhnach
approved these changes
Feb 28, 2025
KazuCocoa
approved these changes
Feb 28, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Feb 28, 2025
## [9.0.6](v9.0.5...v9.0.6) (2025-02-28) ### Bug Fixes * optimize LRU cache ([#985](#985)) ([46dc417](46dc417))
|
🎉 This PR is included in version 9.0.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
[element fb_takeSnapshot:NO]whencheckStalenesswas true.removeObjectForKey:method to remove an object from the LRU cache using its key.Impact: