feat: Add support for the autoClickAlertSelector setting #1002
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KazuCocoa
approved these changes
Apr 10, 2025
| shouldReturnAfterFirstMatch:YES]; | ||
| if (matches.count > 0) { | ||
| [[matches objectAtIndex:0] tap]; | ||
| } |
Member
There was a problem hiding this comment.
Not a strong opinion but would it be helpful to leave log if the element has over 2? So something like <given selector> matches over two elements. clicking the first one for future investigation
Author
There was a problem hiding this comment.
I would like to keep the current behaviour for now as multiple elements matching might be less performant than single element match, and I prefer performance in this scenario
github-actions bot
pushed a commit
that referenced
this pull request
Apr 10, 2025
## [9.5.0](v9.4.1...v9.5.0) (2025-04-10) ### Features * Add support for the autoClickAlertSelector setting ([#1002](#1002)) ([fd31b95](fd31b95))
|
🎉 This PR is included in version 9.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses appium/appium#20938