这是indexloc提供的服务，不要输入任何密码
Skip to content

fix: Missing text in long text for get text/value #1007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 19, 2025
Merged

fix: Missing text in long text for get text/value #1007

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5fc9239
replace long text test
KazuCocoa Apr 18, 2025
db5e0a3
add workaround
KazuCocoa Apr 19, 2025
dca3ca0
here too
KazuCocoa Apr 19, 2025
338c67e
Merge branch 'master' into long-test-test
KazuCocoa Apr 19, 2025
6fceeb8
add comments
KazuCocoa Apr 19, 2025
01202bf
Merge branch 'long-test-test' of github.com:appium/WebDriverAgent int…
KazuCocoa Apr 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions WebDriverAgentLib/Categories/XCUIElement+FBWebDriverAttributes.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@ @implementation XCUIElement (WebDriverAttributesForwarding)
{
BOOL inDepth = [name isEqualToString:FBStringify(XCUIElement, isWDAccessible)]
|| [name isEqualToString:FBStringify(XCUIElement, isWDAccessibilityContainer)]
// To retrice entire text https://github.com/appium/appium-xcuitest-driver/issues/2552
|| [name isEqualToString:FBStringify(XCUIElement, wdValue)]
|| [name isEqualToString:FBStringify(XCUIElement, wdIndex)];
return [self fb_takeSnapshot:inDepth];
}
Expand Down
3 changes: 2 additions & 1 deletion WebDriverAgentLib/Commands/FBElementCommands.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,8 @@ + (NSArray *)routes
{
FBElementCache *elementCache = request.session.elementCache;
XCUIElement *element = [elementCache elementForUUID:(NSString *)request.parameters[@"uuid"]];
FBXCElementSnapshotWrapper *wrappedSnapshot = [FBXCElementSnapshotWrapper ensureWrapped:[element fb_takeSnapshot:NO]];
// 'fb_takeSnapshot:YES' is to retrice entire text https://github.com/appium/appium-xcuitest-driver/issues/2552
FBXCElementSnapshotWrapper *wrappedSnapshot = [FBXCElementSnapshotWrapper ensureWrapped:[element fb_takeSnapshot:YES]];
id text = FBFirstNonEmptyValue(wrappedSnapshot.wdValue, wrappedSnapshot.wdLabel);
return FBResponseWithObject(text ?: @"");
}
Expand Down
Loading
Loading