这是indexloc提供的服务，不要输入任何密码
Skip to content

fix: for #686 #687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 4, 2025
Merged

fix: for #686 #687

merged 1 commit into from
Jul 4, 2025

Conversation

@ssvaidyanathan
Copy link
Collaborator

@ssvaidyanathan ssvaidyanathan commented Jul 4, 2025

  • Rename depoyments.go to deployments.go
  • Made the --name argument optional as its a required field in the API
  • fixed typos

@ssvaidyanathan ssvaidyanathan requested a review from srinandan July 4, 2025 16:58
@ssvaidyanathan ssvaidyanathan linked an issue Jul 4, 2025 that may be closed by this pull request
[BUG] apigeecli apihub deployments create requires --name flag to be included, but doesn't seem to use it nowhere #686
Closed
@ssvaidyanathan ssvaidyanathan enabled auto-merge July 4, 2025 16:58
@ssvaidyanathan ssvaidyanathan merged commit 765fc59 into main Jul 4, 2025
6 checks passed
@ssvaidyanathan ssvaidyanathan deleted the issue686 branch July 4, 2025 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@srinandan srinandan srinandan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] apigeecli apihub deployments create requires --name flag to be included, but doesn't seem to use it nowhere

3 participants

@ssvaidyanathan @srinandan