GH-676: Fix nil pointer panic when setting an HTTP proxy #678
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses a logic error in internal/apiclient/httpclient.go that would only attempt to construct an `ApigeeAPIClient` with an HTTP proxy if the previous operation that attempts to parse the proxy URL failed. This bug results in the API client singleton never being created when the proxy URL is valid, and the singleton is only created if the proxy is unset or has an invalid value. When using a proxy, this issue bubbles up and results in a nil-pointer dereference on the global API client singleton, which crashes the runtime. Inverting the condition addresses this issue. Fixes apigeeGH-676.
kurtkanaskie
approved these changes
Jun 23, 2025
Collaborator
kurtkanaskie
left a comment
There was a problem hiding this comment.
LGTM and Gemini ;)
ssvaidyanathan
approved these changes
Jun 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses a logic error in internal/apiclient/httpclient.go that would only attempt to construct an
ApigeeAPIClientwith an HTTP proxy if the previous operation that attempts to parse the proxy URL failed.This bug results in the API client singleton never being created when the proxy URL is valid, and the singleton is only created if the proxy is unset or has an invalid value. When using a proxy, this issue bubbles up and results in a nil-pointer dereference on the global API client singleton, which crashes the runtime.
Inverting the condition addresses this issue.
Can confirm proxies work as expected once this change is made.
Fixes GH-676.