这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@srinandan
Copy link
Collaborator

No description provided.

@srinandan srinandan requested a review from ssvaidyanathan May 9, 2023 22:46
@ssvaidyanathan
Copy link
Collaborator

Still unclear how this field will fix the issue? I called the Mgmt API with that property set to true and was able to deploy the same revision to two environments part of the same env group. So how will the routing happen? Will this field make sure that the call goes to the latest deployed environment?

@kurtkanaskie
Copy link
Collaborator

There's an error on the query param for the flag:
has: q.Set("sequencedRollout", serviceAccountName)
should be: q.Set("sequencedRollout", sequencedRollout)

@kurtkanaskie
Copy link
Collaborator

Just testing this out now, the use of sequencedRollout true or false does not prevent the deployment to another env in the same envGroup.

The use of generateDeployChangeReport will indicate: "New deployment will not receive any traffic for basepath /notarget, as this basepath is already claimed by proxy notarget in environment test."

It's up to the user in the UI or the tool invoking the APIs to choose to continue with deployment or not. Even in the UI I can ignore the generateDeployChangeReport and deploy to another env in the same envGroup.

@kurtkanaskie
Copy link
Collaborator

Why is generateDeployChangeReport default false?
Shouldn't it be true to prevent unexpected behavior, like having a proxy deployed to 2 envs in the same envGroup?

@ssvaidyanathan
Copy link
Collaborator

Why is generateDeployChangeReport default false? Shouldn't it be true to prevent unexpected behavior, like having a proxy deployed to 2 envs in the same envGroup?

Probably for backward compatibility?

@kurtkanaskie
Copy link
Collaborator

Probably for backward compatibility?

I think that behavior is a bug.

@srinandan srinandan requested a review from kurtkanaskie May 10, 2023 20:03
@srinandan srinandan linked an issue May 10, 2023 that may be closed by this pull request
@ssvaidyanathan ssvaidyanathan self-requested a review May 10, 2023 20:05
Copy link
Collaborator

@kurtkanaskie kurtkanaskie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor editorial on L56

undeployment will proceed...

@srinandan srinandan requested a review from kurtkanaskie May 10, 2023 21:26
@ssvaidyanathan ssvaidyanathan merged commit e01e57c into main May 10, 2023
@srinandan srinandan deleted the issue201 branch June 14, 2023 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deploy same API Proxy

4 participants