这是indexloc提供的服务，不要输入任何密码
Skip to content

MethodSignatureMismatch: Method supportsDenormalization with return type '' is different to return type 'bool' of inherited method #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 18, 2024
Merged

MethodSignatureMismatch: Method supportsDenormalization with return type '' is different to return type 'bool' of inherited method #389

merged 1 commit into from
Oct 18, 2024

Conversation

@kedarkhaire
Copy link
Collaborator

@kedarkhaire kedarkhaire commented Oct 18, 2024

Fixes #383

@kedarkhaire
MethodSignatureMismatch: Method supportsDenormalization with return t…
f32b6e7 
…ype '' is different to return type 'bool' of inherited method
@kedarkhaire kedarkhaire added this to the 4.0.0 milestone Oct 18, 2024
@codecov
Copy link

codecov bot commented Oct 18, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 97.87234% with 1 line in your changes missing coverage. Please review.

Project coverage is 86.68%. Comparing base (c84dd4a) to head (f32b6e7).
Report is 1 commits behind head on 4.x.

Files with missing lines Patch % Lines
src/Serializer/EntitySerializer.php 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##                4.x     #389   +/-   ##
=========================================
  Coverage     86.68%   86.68%           
  Complexity     1737     1737           
=========================================
  Files           343      343           
  Lines          4220     4220           
=========================================
  Hits           3658     3658           
  Misses          562      562
Flag Coverage Δ
unittests 86.68% <97.87%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...geeX/Denormalizer/AcceptedRatePlanDenormalizer.php 85.71% <100.00%> (ø)
...pi/ApigeeX/Denormalizer/ApiProductDenormalizer.php 100.00% <100.00%> (ø)
src/Api/ApigeeX/Denormalizer/AppDenormalizer.php 70.00% <100.00%> (ø)
...eX/Denormalizer/AppGroupMembershipDenormalizer.php 93.33% <100.00%> (ø)
...i/ApigeeX/Denormalizer/BillingTypeDenormalizer.php 85.71% <100.00%> (ø)
...rmalizer/DeveloperAcceptedRatePlanDenormalizer.php 83.33% <100.00%> (ø)
.../Denormalizer/DeveloperBillingTypeDenormalizer.php 83.33% <100.00%> (ø)
...pigeeX/Denormalizer/PrepaidBalanceDenormalizer.php 85.71% <100.00%> (ø)
.../Api/ApigeeX/Denormalizer/RatePlanDenormalizer.php 90.00% <100.00%> (ø)
...igeeX/Denormalizer/RatePlanDenormalizerFactory.php 100.00% <100.00%> (ø)
... and 37 more

divya-intelli
divya-intelli approved these changes Oct 18, 2024
View reviewed changes
Copy link
Collaborator

@divya-intelli divya-intelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kedarkhaire kedarkhaire merged commit d90650c into apigee:4.x Oct 18, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@divya-intelli divya-intelli divya-intelli approved these changes

@giteshk giteshk Awaiting requested review from giteshk

@shishir-intelli shishir-intelli Awaiting requested review from shishir-intelli

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

4.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@kedarkhaire @divya-intelli