chore: Suppress 'as' test is always true warning #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
67943c0 to
b2fa4b4
Compare
b2fa4b4 to
c4944c7
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
Removes unnecessary as ArrowError casts by refactoring loadRecordBatch calls to return a Result instead of throwing, streamlining error handling. Key changes:
- Replaced
do-try-catchblocks for record batch loading withResult-basedswitch. - Eliminated generic
unknownErrorfallback in favor of direct error propagation. - Moved offset and length updates to occur after successful batch processing.
Comments suppressed due to low confidence (2)
Arrow/Sources/Arrow/ArrowReader.swift:257
- Add unit tests for the
failurebranch ofloadRecordBatchin each context to verify error propagation and confirm offset updates only happen on success.
switch recordBatchResult {
Arrow/Sources/Arrow/ArrowReader.swift:251
- With the generic catch removed, ensure that
loadRecordBatchcan only fail withArrowError; otherwise unhandled errors might escape and lead to crashes.
let recordBatchResult = loadRecordBatch(
Comment on lines
+257
to
+260
| switch recordBatchResult { | ||
| case .success(let recordBatch): | ||
| result.batches.append(recordBatch) | ||
| offset += Int(message.bodyLength + Int64(length)) | ||
| length = getUInt32(input, offset: offset) | ||
| } catch let error as ArrowError { | ||
| case .failure(let error): |
There was a problem hiding this comment.
[nitpick] This switch recordBatchResult block is repeated multiple times; consider extracting a helper method to append batches and propagate errors to reduce duplication.
Member
Author
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's Changed
Remove needless
as ArrowErrors because all errors must beArrowErrorhere.Closes #52.