Tags: antonyggvzvmnxxcx/wpt
Tags
Fix flaky test layout-instability/input-timestamp.html layout-instability/input-timestamp.html test is flaky because we are waiting for 500ms to change the layout after a click event. The click event should report a layout shift entry to PerformanceObserver with hadRecentInput to be true, the layout shift of the div will report another layout shift entry to PerformanceObserver with hadRecentInput to be false. 500ms is the interval of the excluding input window, so if we just set the timeout to be 500ms, the test is flaky, because the click event may not executed right away. I change the time delay to be 600ms to reduce the flakiness. Bug: 1221422 Change-Id: Ib960d98fe7ac7d0806a7152052465e9188afb2a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3032268 Reviewed-by: Annie Sullivan <sullivan@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#902699}
[COEPForSharedWorker] Do not block worker with incompatible COEP Bug: 1226550 Change-Id: Id037a95461ac7931b0c14d62f0e7a295db06dd9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3035102 Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Yifan Luo <lyf@chromium.org> Cr-Commit-Position: refs/heads/master@{#902490}
[LayoutNG] Consider OOF positioned nodes as IsManagedByLayoutNG. positioned: fixed NG elements whose containing block was the LayoutView had issues (the legacy kind) with scrollbars. We can avoid these issues by letting IsManagedByLayoutNG return true when OOF. These are basically "managed" by NG as they are laid out via. the NGOutOfFlowLayoutPart. The other callers of IsManagedByLayoutNG should also be fine with this change. 1) https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/frame/local_frame_view.cc;l=1539?q=ismanagedbylayoutng&ss=chromium Should be fine, OOF doesn't need to be pre-laid-out. 2) https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/layout/depth_ordered_layout_object_list.cc;l=53?q=ismanagedbylayoutng&ss=chromium Should also be fine as OOF? Bug: 1225548 Change-Id: I42c4551382553ea52edc5f2ada94ce74d570c6bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3033195 Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#902402}
[LayoutNG] More OOF writing mode fixes in multicol 1. Previously, we had used the writing mode of the CB when setting up the NodeInfo in NGOutOfFlowLayoutPart. However, we want to use the writing mode of the builder instead since the OOF will be laid out inside the fragmentainer children of the builder rather than the CB itself (in the case of fragmentation). 2. When creating the CB rect for inline CB's, the start offset that was used was relative to the inline's containing block. However, since the OOF is laid out inside the fragmentainers, we need to convert the inline CB's rect to take the writing mode of the multicol into account. The added tests are similar to those added in CL:3025848, but they apply block/inline insets rather than using the static position. The tests added in CL:3025848 were moved to a common directory as those added in this CL. Bug: 1228746 Change-Id: I6073683137d3bf58eea8ce6f355321e75046fb50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3032909 Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/master@{#902447}
Update navigator.ink.requestPresenter() to use a dictionary param requestPresenter took in two params, a String |type| and an Element |presentationArea|. The goal of the |type| param was to enable requestPresenter() to be easily extensible in the future for other types of presenters. However, in its current state, it is a no-op param. For this reason, after some discussion ([1], [2], [3]) it has been decided that the API should be updated to instead just use a dictionary param. This will still be easily extensible in the future, but won't require a string param until then. [1]: WICG/ink-enhancement#20 [2]: w3ctag/design-reviews#473 (comment) [3]: https://groups.google.com/a/chromium.org/g/blink-dev/c/ZtqwKR_HIAE Bug: 1052145 Change-Id: I9ef18a04ab150fff8c8f173bfa209e10d90781f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3027884 Reviewed-by: Daniel Libby <dlibby@microsoft.com> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Ken Buchanan <kenrb@chromium.org> Commit-Queue: Mario Bianucci <mabian@microsoft.com> Cr-Commit-Position: refs/heads/master@{#902434}
[Sanitizer API] Move tests to WPT suite. Bug: 1184655 Change-Id: I8d1279df84633683b7c42e0d344ee6d5094aa64a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3026791 Reviewed-by: Yifan Luo <lyf@chromium.org> Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#902400}
Rename scrollbar-gutter "mirror" to "both-edges" For clarity, the "mirror" value of the scrollbar-gutter property has been renamed to "both-edges". The functionality remains the same. CSS WG: w3c/csswg-drafts#6349 Bug: 710214 Change-Id: I65683037e083f2edee21451f54a9ef34374d0988 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3026774 Reviewed-by: Philip Rogers <pdr@chromium.org> Commit-Queue: Felipe Erias <felipeerias@igalia.com> Cr-Commit-Position: refs/heads/master@{#902287}
Fix flaky test layout-instability/input-timestamp.html layout-instability/input-timestamp.html test is flaky because we are waiting for 500ms to change the layout after a click event. The click event should report a layout shift entry to PerformanceObserver with hadRecentInput to be true, the layout shift of the div will report another layout shift entry to PerformanceObserver with hadRecentInput to be false. 500ms is the interval of the excluding input window, so if we just set the timeout to be 500ms, the test is flaky, because the click event may not executed right away. I change the time delay to be 600ms to reduce the flakiness. Bug: 1221422 Change-Id: Ib960d98fe7ac7d0806a7152052465e9188afb2a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3032268 Reviewed-by: Annie Sullivan <sullivan@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#902699}
Rename scrollbar-gutter "mirror" to "both-edges" For clarity, the "mirror" value of the scrollbar-gutter property has been renamed to "both-edges". The functionality remains the same. CSS WG: w3c/csswg-drafts#6349 Bug: 710214 Change-Id: I65683037e083f2edee21451f54a9ef34374d0988 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3026774 Reviewed-by: Philip Rogers <pdr@chromium.org> Commit-Queue: Felipe Erias <felipeerias@igalia.com> Cr-Commit-Position: refs/heads/master@{#902287}
Fix flaky test layout-instability/input-timestamp.html layout-instability/input-timestamp.html test is flaky because we are waiting for 500ms to change the layout after a click event. The click event should report a layout shift entry to PerformanceObserver with hadRecentInput to be true, the layout shift of the div will report another layout shift entry to PerformanceObserver with hadRecentInput to be false. 500ms is the interval of the excluding input window, so if we just set the timeout to be 500ms, the test is flaky, because the click event may not executed right away. I change the time delay to be 600ms to reduce the flakiness. Bug: 1221422 Change-Id: Ib960d98fe7ac7d0806a7152052465e9188afb2a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3032268 Reviewed-by: Annie Sullivan <sullivan@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#902699}
PreviousNext