这是indexloc提供的服务，不要输入任何密码
Skip to content

Fix Google Calendar Time Range #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix Google Calendar Time Range #356

wants to merge 2 commits into from

Conversation

@tembo
Copy link
Contributor

@tembo tembo bot commented Sep 2, 2025 •
edited by cubic-dev-ai bot
Loading

Description

Resolve Google Calendar API error caused by empty time range parameters

Changes

  • Added time range validation for events and free busy methods
  • Prevent empty time range errors by comparing timeMin and timeMax
  • Enhanced error logging with additional context
  • Improved error handling for time-related API calls

Want me to make any changes? Add a review or comment with @tembo and i'll get back to work!

tembo.io sentry.io

Summary by cubic

Fixes Google Calendar timeRangeEmpty errors by validating timeMin/timeMax and sending only valid UTC instants to the API. Also improves error logs with helpful context for faster debugging.

  • Bug Fixes
    • Validate timeMin/timeMax (as UTC Instants); throw if timeMax is not after timeMin.
    • Use validated instants in events.list and freeBusy requests.
    • Add structured error context (calendar/schedule IDs, time range, accountId, operation) and clearer messages for time range failures.

@tembo
fix(google-calendar): prevent timeRangeEmpty errors with validation
eccbc47 
- Add time range validation in events() and freeBusy() methods
- Ensure timeMax is always after timeMin before API calls
- Enhanced error logging for time range validation failures
- Add context logging with calendar/schedule details for debugging
@vercel
Copy link

vercel bot commented Sep 2, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
analog Ready Ready Preview Comment Sep 2, 2025 11:15am

@tembo
Copy link
Contributor Author

tembo bot commented Sep 2, 2025

Requesting review from @JeanMeijer who has experience with the following files modified in this PR:

  • bun.lock
  • apps/web/next-env.d.ts
  • packages/api/src/providers/calendars/google-calendar.ts

@tembo tembo bot requested a review from JeanMeijer September 2, 2025 11:10
@coderabbitai
Copy link

coderabbitai bot commented Sep 2, 2025

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Join our Discord community for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@tembo
Copy link
Contributor Author

tembo bot commented Sep 2, 2025

Tembo is working on fixing this failing workflow: Check formatting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JeanMeijer JeanMeijer Awaiting requested review from JeanMeijer

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant