-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Make FragmentScenario closeable #120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make FragmentScenario closeable #120
Conversation
Test: ./gradlew paging:paging-samples:lintDebug Change-Id: Id78218dd37260d4edc5e30ed00631234a0d2d21d
Instead of reading values from legacy wear settings provider, we will read the value from Settings.Global starting from R. Bug: 176894971 Test: androidx.wear.phone.interactions.PhoneTypeHelperTest Change-Id: I944e78e3d971022bcf5b755dbc284eedfb18025b
Test: Presubmit Relnote: UserStyle now has an array operator and we've added casting helpers to UserStyle.Option. Change-Id: I35036a0d62b14cda9e7c12fb55a256ed279af432
This CL deprecates tapGestureFilter, dobuleTapGesutreFilter, longPress and indication ones. Migrated all the usages to a new Modifier.pointerInput. Took a liberty to make a few adjustments in detectTapGestures function, namely: adding Offset param to all the callback + make onTap nullable. Change-Id: I6baf95f881b6fa6890ca1d065d49fef3e27bce83 Relnote: "tapGestureFilter, doubleTapGestureFilter, longPressGestureFilter and pressIndicaitonGestureFilter have been deprecated. Use Modifier.clickable or Modifier.pointerInput with detectTapGestures function instead." Bug: 175294473 Test: migrated as well
Also changes BottomNavigationItem back to being an extension on RowScope. BottomNavigationItems are equally spaced within a `BottomNavigation`, so by adding `RowScope` we can express this contract as part of the API. We previously removed this but having this contract makes it a lot harder to misuse the component and run into strange cases where the weight is not applied. Also adds `Tab` role to BottomNavigationItem for accessibility purposes. Fixes: b/152764416 Test: updateApi Relnote: "Added enabled parameters to Tab and BottomNavigationItem, to prevent them from being clickable. Changed BottomNavigationItem to be RowScope.BottomNavigationItem to better express its layout requirements in its API." Change-Id: Id683dc9a558c8d0704306a1c7f307985a9dbb12f
Bumping so navigation-compose can pull the latest compose apis Test: ./gradlew navigation:navigation-compose:integration-tests:navigation-demos:compileDebugKotlin This is an imported pull request from androidx#118. Resolves androidx#118 Github-Pr-Head-Sha: ac5fad7 GitOrigin-RevId: 6cb3df3 Change-Id: Id42fa78434d2d42b097b421c687c2e4fd9b2350e
Instead of unblocking remote prepend / append after refresh succeeds, we now allow them to get added to pendingRequests in case refresh does not trigger invalidation or if invalidation + requesting prepend / append happens before blockState can get updated. This prevents paging from getting stuck in weird race cases, but allows potentially out-of-date remote requests to go through, where remote prepend or append has PagingState from last generation. Fixes: 176855944 Test: ./gradlew paging:paging-common:test Change-Id: I5953023eda28cfd7c1a7da334920cba513a564c6
…into androidx-main
Fixes: 178121834 Test: new test added Change-Id: I97615270d0a6d8bdc7e5dd7b3ae744ea7fdf3ad2
Bug: 178173755 Test: LayoutInspectorTreeTest Change-Id: Iab15c1ce50a7647e2a1b06b0a4c302d713087d41
Fixes: 178173758 Test: ComposeViewAdapter#previewInClass Change-Id: I1c948226ebd774d2a57ede546a3e84aff7605044
…nto androidx-main
Transition v2 introduced different APIs to create transition animations, as well as changes in the infrastructure. It doesn't rely on animation clock observers/observable but in the new coroutines-based clock instead, and the animations are part of the composition life-cycle. Since a lot has changed in the framework, we also need to make changes in ui-tooling to take into account the new infrastructure and APIs. Here is a summary of what has been done: * ComposeAnimationParser now parses Transition objects (instead of TransitionAnimation) into ComposeAnimation. * In ComposeViewAdapter, we look for updateTransition() calls in the Slot Table (as opposed to transition()). Instead of looking for TransitionModel and passing their animation's AnimationClockObserver to the PreviewAnimationClock, we look for Transition objects to and pass them directly to the clock. Furthermore, the PreviewAnimationClock is not provided as an AmbientAnimationClock anymore, but simply used to track and control the animations. * PreviewAnimationClock is no longer a AnimationClockObservable and do not rely on the subscribe/unsubscribe logic nor uses an underlying ManualAnimationClock. Instead, it keeps track of the Transition objects to control them directly. When the clock time is set from Android Studio, we call Transition#seek() accordingly. When getAnimatedProperties() is called, we query the Transition animations' values. * Transition v1 will be deprecated, therefore there is no point in maintaining tooling support for it, so it was removed. Bug: 177841191 Test: PreviewAnimationClockTest and ComposeViewAdapterTest Change-Id: I8bb0ea6a3cb27a8ef6c7c133593defc8d0b27ddf
Could you try rebasing and see if the checks pass now? |
…com/simonschiller/androidx into feature/fragment-scenario-closeable
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
1 similar comment
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
Looks like I messed up the rebase 😅 Let me fix it and open another PR (see #121). |
Proposed Changes
Testing
Test: See JUnit test
Issues Fixed
Fixes: 143774122