Can set all day of the week on the first day #933
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Why should be Tuesday the first day of the week? |
Contributor
|
Please describe some actual use cases dor this change. |
|
In the project I'm working on, the system needed to define Tuesday as the first of the week. In the system, machines that are organized by the system treat Tuesday as the first of the week. So I needed that feature. |
Contributor
|
This makes no sense to add it to the internal code as we have just 3 different variants in the world: |
Contributor
|
This would also break the current behavior. |
DanielRuf
reviewed
Mar 31, 2018
DanielRuf
suggested changes
Mar 31, 2018
Contributor
DanielRuf
left a comment
There was a problem hiding this comment.
This also breaks old setups. We need a better solution here.
Owner
|
Not a problem in v5 :) Closing this as most people don't need to set it to Tuesday |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #894
The current can set 0(Sunday) or 1(Monday) to first day options. But I want set 2(Tuesday).
So it was modified that it can be set to 0 to 6 options of first day.