Remove reference to $root on teardown #868
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The setTimeout function needs access to the $root variable even after teardown. Leaving the reference will leak the $root dom element after setTimeout runs. Memoize the reference to $root so that timeout can run, but remove it in the stop() after it calls close().
Author
|
Looks like there are some tests that depend on |
Contributor
|
Please either update the unit tests or change your implementation. |
DanielRuf
suggested changes
Mar 31, 2018
Contributor
DanielRuf
left a comment
There was a problem hiding this comment.
Please either update the unit tests or change your implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The setTimeout function needs access to the $root variable even after
teardown. Leaving the reference will leak the $root dom element after
setTimeout runs. Memoize the reference to $root so that timeout can run,
but remove it in the stop() after it calls close().