Allow mock Date object in isDate() check #857
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Not sure why Travis CI is failing - can't imagine how this would break things. Maybe to do with it being the last day of the month? >> Message: Able to disable today
>> Actual: [
>> 2016,
>> 2,
>> 32
>> ]
>> Expected: [
>> 2016,
>> 3,
>> 1
>> ] |
Contributor
|
It seems it was due to the overflow. You can check this with the current master on your machine by changing the system clock. |
DanielRuf
reviewed
Apr 1, 2018
Contributor
DanielRuf
left a comment
There was a problem hiding this comment.
Please rebase on the current head of master
Author
|
@DanielRuf I believe that's done now. I've also ticked "Allow edits from maintainers." in case you want to change something further yourself. Thanks. |
DanielRuf
suggested changes
May 3, 2018
Contributor
DanielRuf
left a comment
There was a problem hiding this comment.
The changes probably cause the failing unit tests.
Can you investigate and test them?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When carrying out automated testing (e.g. with Selenium), and wanting to test different timezones, it's common to mock the global Date object with a library like: https://github.com/plaa/TimeShift-js
Unfortunately, the
isDatecheck in pickadate has a very strict check, which rejects anything that isn't a native JSDateobject, rendering this mocking method unusable.I propose making this check more lenient, so as long as the object looks like it matches the
DateAPI, it's allowed through.The issue manifests itself in an interesting way -- you end up with a calendar where, in the best case, every single date shows as today, and in the worst case, browser freezes up in an infinite loop.