这是indexloc提供的服务，不要输入任何密码
Skip to content

Sometimes there is no this, only window. #806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 3, 2019
Merged

Sometimes there is no this, only window. #806

merged 1 commit into from
Apr 3, 2019

Conversation

@cDima
Copy link
Contributor

@cDima cDima commented Dec 8, 2015

Fixes scenarios where the library is called with undefined this, yet there is a browser global window object.

@jtrollia
Copy link

jtrollia commented Jul 26, 2016

👍

@DanielRuf
Copy link
Contributor

DanielRuf commented Feb 15, 2018

Personally I would prefer bebraw/libumd@f43a331

@DanielRuf DanielRuf self-assigned this Feb 24, 2018
@DanielRuf DanielRuf self-requested a review March 31, 2018 20:58
@amsul amsul merged commit 0f971e8 into amsul:master Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@DanielRuf DanielRuf DanielRuf approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@DanielRuf DanielRuf

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cDima @jtrollia @DanielRuf @amsul