bind click and focus events when editable #800
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
There is a test failure in CI. When I ran test locally, the same test failed on master before I made any modifications. It looks like it might be a timezone/DST issue. |
DanielRuf
suggested changes
Apr 1, 2018
Contributor
DanielRuf
left a comment
There was a problem hiding this comment.
Please rebase on the current head of master.
81e521b to
cb1bfb7
Compare
Contributor
Author
|
@DanielRuf 👍rebased |
Contributor
|
Thanks for your contribution and spotting this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
editableoption is set to true, the picker will not open when clicked. When the picker is editable, keyboard events are not bound to the input element. It looks like binding for click and focus events were moved inside the conditional and are only put in place when the picker is not editable.