fixed bugs and added a today function #784
Conversation
bug fixes: Removed "s" from "autofocus" and "u" "date-value" Removed two obsolete input forms Added a function to return current date
|
So far so good but why were the date formats changed? |
|
Not yet sure if the failing tests are related. |
|
Honestly I forgot what the issue is about, it's been more than two years :) |
|
Can you rebase the PR on the current head of master? |
|
will do that next weekend probably |
Friendly bump =) |
|
yeah will do it tomorrow promise i'll put it as a reminder, im at work now, cant |
|
take my word on it, tomorrow will work on it |
No problem and no hurry, just wanted to remind you that you have a PR open =) |
|
What I don't understand is that all I did is editing a test file, which I don't remember a thing about since it was 2015, but anyhow if all I did is adding a test which is breaking the build then why not just delete the test and close the issue? I mean isn't just a test? I don't see any changes in lib folder, so I broke a test and didn't contribute to the core library. Anyhow I'll rebase |
|
I closed the issue and deleted the pull request, I don't see any value in the code I've written |
|
it was failing because in the newer version, you're pulling jquery from the node_modules and you're not shipping it with the repo. |
|
jQuery should be never shipped with a library =) |
|
And still: a rebase or pushing an empty commit to trigger a new build would have fixed it. https://travis-ci.org/amsul/pickadate.js/builds/87535668 This is just related to the previous setup. |
|
Still, your PR is good. Would like to see it reopened and a new build trggered =) |
|
|
|
cant reopen it, the opening button is disabled
|
|
Ill open a new issue |
bug fixes:
Removed "s" from "autofocus" and "u" "date-value"
Removed two obsolete input forms
Added a function to return current date