Browserify branch updates #772
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@amsul Looks like there's a bit of work outside of the updates I've made here to get it working with the tests. Regardless, these changes were required for me to use this repo with Browserify, so I can Based on the comments by @mogarick #365 I'm currently using my own fork, but it'd be great to get this repo updated, it's an awesome plugin so thanks for the work you've put in so far. |
|
👍 |
bryanlarsen
added a commit
to bryanlarsen/pickadate.js
that referenced
this pull request
Oct 12, 2015
Merged
|
Why hasn't this been merged? |
|
@rattrayalex good question |
|
Does it need to be rebased or something? Would be happy to help if possible... |
Contributor
|
At least there are failing unit tests. Also I guess this is obsolete now as there is already this |
Contributor
|
Can we close this? |
Contributor
|
Closing for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
undefunused variable error in Travis test