这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@jespr
Copy link

@jespr jespr commented Jan 29, 2013

Some languages shows the year before the month. I've added an option to toggle that.

Screen Shot 2013-01-28 at 4 00 48 PM

@amsul amsul closed this Apr 27, 2013
@jespr
Copy link
Author

jespr commented Apr 28, 2013

So that was a no go? :)

@amsul
Copy link
Owner

amsul commented Apr 28, 2013

Oh! Sorry for not giving a timely response to this PR and for the lack of discussion here. I think I accidentally closed this request yesterday while sorting through the other tickets.

I initially didn’t merge this in because this seems to be more of a layout thing than that of functionality. And with CSS getting better, the same affect can be achieved using ordinal groups which seem to have quite good browser support.

On the other hand, if support for older browsers is important, we could also go this route:

onStart: function() {
    var $month = $( '.pickadate__month' ).detach();
    $( '.pickadate__year' ).after( $month )
}

I would definitely prefer this over adding another option to the plugin - just my two cents. :)

@brianmhunt
Copy link

Out of interest, here's a gist for a flexbox less-mixin, that I think is awesome. Cheers.

ps. great to see 3.0 on the horizon! Love it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants