Make sure $.fn.pickadate and $.fn.pickatime have been defined before set up translations #744
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…set up translations
|
@amsul could you please merge it? It's quite annoying to have always the |
|
👍 please merge this. |
|
merge would be great. Thank you |
|
👍 please merge. this breaks my site and I have the pickadate.js loaded before the translation. |
|
👍 merge, please |
Contributor
|
This PR has currently conflicts. The compressed files should not be changed or pushed. I'll try to resolve the conflict. |
DanielRuf
suggested changes
Apr 1, 2018
Contributor
DanielRuf
left a comment
There was a problem hiding this comment.
Also we should use an extra helper for this. It makes not much sense to edit all files like this.
Owner
|
Coming around to this finally 😅 Yeah this is a bit much..Simply changing the order of the imports would fix this problem as well. Anyways, not a problem in v5 :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #742