Corrected behavior when both value and data-value attributes are set #386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. removed invalid character in line 581
2. changed determination of 'fromValue' flag on init.
When having a node like this:
<input value="2014-04-10" data-value="2014-04-10" />
And initializing pickadate like:
$("input").pickadate( {formatSubmit: "yyyy-mm-dd"});
The *expected* behaviour is to set the date to April 10, 2014.
The previous implementation took the value from data-value but determined the fromValue flag by evaluating !!elementValue. This means, as long as value-attribute is set, the data-value attribute is treated with zero-based month-index, so the date would be set to March 10, 2014.
Owner
|
Thanks for the fix..Closing this in favor of #358 as that fixes it in an alternate way. Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When having a node like this:
And initializing pickadate like:
The expected behaviour is to set the date to April 10, 2014.
The previous implementation took the value from data-value but determined the fromValue flag by evaluating !!elementValue. This means, as long as value-attribute is set, the data-value attribute is treated with zero-based month-index, so the date would be set to March 10, 2014.