Realised I edited the build files and not the source files. Expect a fix shortly.

I was initially going to merge this in, but now I’m starting to reconsider. There was another PR (#75) much earlier that suggested this as well.

But I think the appropriate way to resolve is with a formatSubmit:

$( '.datepicker' ).pickadate({
    format: 'd mmmm, ‘yy',
    formatSubmit: 'yyyy-mm-dd'
});

This ensures the date will be parsed correctly :). I’ll update the docs to explicitly state this.

Cheers!

Does this pass the tests in this pull request?—
Rolf

On Sun, Apr 13, 2014 at 12:19 AM, amsul notifications@github.com wrote:

I was initially going to merge this in, but now I’m starting to reconsider. There was another PR (#75) much earlier that suggested this as well.
But I think the appropriate way to resolve is with a formatSubmit:

$( '.datepicker' ).pickadate({
    format: 'd mmmm, ‘yy',
    formatSubmit: 'yyyy-mm-dd'
});

This ensures the date will be parsed correctly :). I’ll update the docs to explicitly state this.

Cheers!

Reply to this email directly or view it on GitHub:
#367 (comment)

Yup, it would - so long as you also have a data-value attribute.

Please give the tests a run, because the issue is deeper than just date formatting.  —
Rolf

On Sun, Apr 13, 2014 at 12:34 AM, amsul notifications@github.com wrote:

Yup, it would - so long as you also have a data-value attribute.

Reply to this email directly or view it on GitHub:
#367 (comment)

What’s the deeper issue?

The tests are incomplete as they are.. there’s no formatSubmit specified and there’s no data-value attribute.

It's been a while, but if I remember correctly it doesn't parse the date correctly, and it doesn't pick the century you would assume it would. This was inspired fix by moment.js. —
Rolf

On Sun, Apr 13, 2014 at 12:44 AM, amsul notifications@github.com wrote:

What’s the deeper issue?

The tests are incomplete as they are.. there’s no formatSubmit specified and there’s no data-value attribute.

Reply to this email directly or view it on GitHub:
#367 (comment)

Yes, it definitely wouldn’t parse correctly without a data-value attribute that doesn’t use yy.

There’s nothing wrong with the fix. It makes sense that moment.js would do that - it’s a date parsing library.

But for the purposes of a date picker, if the value you present to your user is formatted yy, you should be saving the value in your database with yyyy.

I agree that it should be, but our usage of the date picker doesn't save the date  anywhere as we treat is as a pass through value which is short lived and I tried setting everything as per the instructions in the manual but it didn't work. Not in front of my computer so I can't check if your configuration works for our use case yet. Thanks for following up. —
Rolf

On Sun, Apr 13, 2014 at 12:53 AM, amsul notifications@github.com wrote:

Yes, it definitely wouldn’t parse correctly without a data-value attribute that doesn’t use yy.
There’s nothing wrong with the fix. It makes sense that moment.js would do that - it’s a date parsing library.

But for the purposes of a date picker, if the value you present to your user is formatted yy, you should be saving the value in your database with yyyy.

Reply to this email directly or view it on GitHub:
#367 (comment)

Ah, I see. Well the instructions have been updated - which will be on the live site by the end of the weekend :)

dd.mm.yy still parsing as 1900