这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@p-j
Copy link
Contributor

@p-j p-j commented Nov 14, 2013

No description provided.

@amsul
Copy link
Owner

amsul commented Nov 16, 2013

Thanks for the submission and typo fix!

I don’t speak French myself - but as far as my experience with it goes, I believe months & weekdays are not supposed to be capitalized. Can anybody confirm this?

@amsul
Copy link
Owner

amsul commented Nov 16, 2013

After a bit of Googling, it definitely seems like months and weekdays should not be capitalized. Not sure about “Today” and “Clear” though..

@p-j
Copy link
Contributor Author

p-j commented Nov 17, 2013

Depends how you write it. In a sentence I confirm it shouldn't, but in a
calendar it would usually be. By the way, I'm French, living in France, and
I sent that pull request because it shocked me quite a bit that they
weren't capitalized. Anyway, if it's not to be merged, I'll just fixe it
myself in my implementation :-)
Le 16 nov. 2013 22:03, "amsul" notifications@github.com a écrit :

After a bit of Googling, it definitely seems like months and weekdays
should not be capitalized. Not sure about “Today” and “Clear” though..


Reply to this email directly or view it on GitHubhttps://github.com//pull/273#issuecomment-28635731
.

@amsul
Copy link
Owner

amsul commented Nov 18, 2013

You are definitely correct. I will merge this in soon :)

@amsul amsul merged commit 5852259 into amsul:dev Dec 5, 2013
@p-j p-j deleted the patch-1 branch December 10, 2013 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants