When the picker is in a modal popup like MagnificPopup, the click handler on document are in conflict on Chrome/Linux. #249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dler on document are in conflict on Chrome/Linux.
Author
|
Patch tested on Chrome 30 / Ubuntu 13.04 and Firefox 24 / Ubuntu 13.04 Reproduced here : http://codepen.io/vtabary/pen/wIqAB |
|
I've the same problem, please accept this PR |
|
Agreed, having the same problem, and this fixes it perfectly. Please accept the PR! |
Owner
|
Alright guys.. I finally came around to taking a look at this. Seems like it’s the same issue as #120. This isn’t an issue with pickadate – it’s actually a problem with MagnificPopup and jQuery mobile hogging the mousedown event and switching the focused element. Although I am including this fix in the next release, this issue should be reported to the other projects as bugs. Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Chrome/Linux, when the date picker is in a modal like MagnificPopup (http://dimsemenov.com/plugins/magnific-popup/), two events handler on $document for click are in conflict.
The method event.stopPropagation() in P.$root.on('click') is not sufficient, we have to prevent default behavior too with event.preventDefault().