Set pointer capture on pointerdown on picker input #1167
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chrome 73 starts sending click even to the common ancestor of down and up events even when one was inside the input element and the other one was outside. This caused this library to fail in the following scenario: User presses down on the picker input which causes the date picker and overlay to be shown. When user releases the button the overlay gets the up event and the common ancestor of these elements will get the click. Since there is a click handler on the document to close the popup, the calendar popup immediately closes. Using pointercapture API to capture the rest of the pointerevents stream to the picker input it ensures the click event target is the picker input and that ensures the click handler doesn't dismiss the popup.
NavidZ
referenced
this pull request
May 13, 2019
Contributor
|
Hi @NavidZ, Please check the failing tests. |
Contributor
|
Also this will not work in older browsers. We will not merge this solution for the regression bug for v3. As others already wrote, revert the change and provide a proper migration path. https://bugs.chromium.org/p/chromium/issues/detail?id=941910 You already confirmed that this is a regression bug in Chromium and we will not add other workarounds or solutions like this for one specific browser bug. I still not understand why the Chromium developers do not simply revert or fix this and push the responsibility to us library maintainers. Pickadate 3.6.3 works without any problems so we do not need this vendor specific solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chrome 73 starts sending click even to the common
ancestor of down and up events even when one was
inside the input element and the other one was
outside. This caused this library to fail in the
following scenario:
User presses down on the picker input which causes
the date picker and overlay to be shown. When user
releases the button the overlay gets the up event
and the common ancestor of these elements will get
the click. Since there is a click handler on the
document to close the popup, the calendar popup immediately
closes.
Using pointercapture API to capture the rest of the
pointerevents stream to the picker input it ensures
the click event target is the picker input and that ensures
the click handler doesn't dismiss the popup.