Use fixed Positioning #1134
Use fixed Positioning #1134
Conversation
Use fixed positioning to avoid the clipping that is seen when the picker modal is generated inside an element with overflow scroll or hidden.
|
Absolute |
|
Fixed Positioning |
DanielRuf
left a comment
There was a problem hiding this comment.
This is a breaking change imo and I think this should be an optin solution or just documented.
|
Hi @DanielRuf what is broken on this change? Fixed position uses the view port as its frame of reference, absolute uses the nearest parent element with position set to relative. In theory for use as a modal fixed positioning would offer a more sturdy base point. |
|
@MatthewKennedy this is a breaking change because previous versions of this library use If your parent element prevents filling the entire window, you might find the container option more suitable for your needs: https://amsul.ca/pickadate.js/date/#container |
|
Not only that, but anyone can add the CSS in this PR to their own stylesheets if that's what they prefer :) |
|
Both good suggestions, I'll play around with the container setting from the js. |
|
@MatthewKennedy I'm gonna assume this is safe to close :) |
Use fixed positioning to avoid the clipping that is seen when the picker modal is generated inside an element with position relative & overflow set to scroll or hidden.