这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@elieobeid7
Copy link
Contributor

  • Added today function so that today works in datepicker
  • Fixed Typos
  • Removed unused input
  • Added tags

elieobeid7 added 4 commits May 6, 2018 01:03
added missing html tags and fixed autofocus typo
- Added missing html tags
- Fixed typo errors
- Removed unused input fields
- Added a today function so that today would work in the plugin
fixed typo errors, html tags and added today function
@DanielRuf DanielRuf self-requested a review May 5, 2018 23:13
@elieobeid7
Copy link
Contributor Author

Sorry for the stupid question but it's been a while since the last time i did pull request on github

  • Do you need anything else from me? I delete my fork? Will you merge the changes or is there things I need to do?

  • Could you add --verbose to npm install in travis? npm install --verbose, so that when npm fails we'll know why, I didn't see verbose argument in the last travis build and I don't know how travis work, maybe I'm missing something

@DanielRuf
Copy link
Contributor

Please do not delete your fork or branch until it is merged.

Your PR looks good so far 👍

--verbose is not needed as the output and stacktraces should be already sufficient if something fails.

Also --verbose is not needed for CI and the builds would take longer.

@elieobeid7
Copy link
Contributor Author

Okay, by the way the date picker won't work if I remove the today code that I've written. Maybe it's just me maybe not.

In any case, I think it's best to remove

var today = new Date();
var dd = today.getDate();
var mm = today.getMonth() + 1; //January is 0!
var yyyy = today.getFullYear();
if (dd < 10) {
	dd = '0' + dd;
}
if (mm < 10) {
	mm = '0' + mm;
}
today = dd + '/' + mm + '/' + yyyy;

From date.html and put it in picker.date.js

@DanielRuf
Copy link
Contributor

DanielRuf commented May 6, 2018

Not needed in my opinion as this is just logic for the unit tests and the related files. Testcode should not be in the core files of a library.

@DanielRuf DanielRuf merged commit 1b294b8 into amsul:master Jun 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants