这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@andrewpthorp
Copy link
Contributor

This pull request adds a callback for onRender. This callback would fire every time the calendar is rendered, both when prev/next arrow are clicked as well as the initial render.

We use pickadate and push some custom header text into the DOM. It became apparent that we needed a hook everytime the calendar was rendered to repush that text, but we currently only had the ability to push it whent he calendar was first opened.

I didn't minify the JS because I couldn't figure out which tool you were using to do that. If you want me to minify it, I can do that. I also took the liberty to do a minor version bump, so I hope you don't mind. There were no notes in the Contributing section about how you like to handle that.

Thanks!
@andrewpthorp

amsul added a commit that referenced this pull request Mar 21, 2013
Added `onRender` callback
@amsul amsul merged commit 6c61888 into amsul:dev Mar 21, 2013
@amsul
Copy link
Owner

amsul commented Mar 21, 2013

Awesome! This was definitely a much needed method.

Thanks for such a complete PR 😄. I'll add some more notes to the readme file in regards to minifying and contributing.
Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants