Bind events to P.$holder again when render()
#648
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The event bindings seem to be lost after `render` is invoked with the argument `entireComponent = true`. This adds it back again. https://github.com/amsul/pickadate.js/blob/gh-pages/CONTRIBUTING.md seems to be missing so I'm not sure what else is needed.
Owner
|
@draco this is great, thanks! If you can please resubmit a PR to the Cheers. |
Owner
|
All good..merged into Cheers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The event bindings seem to be lost after
renderis invoked with the argumententireComponent = true. This adds it back again.