* Fix iOS 8 error when opening/closing time picker over and over #629
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
This split doesn’t actually do the same thing as the original code. In fact, the second line is just going to be ignored by all browsers because it’s invalid CSS. I have a fix locally for this - will push it soon. I'll give you more info on Gitter. |
|
Was able to resolve by commenting out the transitions on the .picker__holder. .picker__holder {
position: fixed;
/*transition: background 0.15s ease-out, -webkit-transform 0s 0.15s;
transition: background 0.15s ease-out, transform 0s 0.15s;*/
-webkit-backface-visibility: hidden;
}Side effect is the control isn't placed on the bottom of the window, but is now usable in Safari iOS 8 for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue with iOS 8 when opening and closing the time picker over and over. On subsequent clicks, the time picker would intermittently open without actually appearing. Clicking again would select a time as though it was there, then close it.
iOS 8 seemed to be hung up on this line, which combines
transitionandtransformrules. Splitting them into two fixed things.You can view the problem here and the fixed version here. (Note that there is also some extra scroll-jumping on that page to work around #609).