-
Notifications
You must be signed in to change notification settings - Fork 1k
Fix for fields wrapped in a label #616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Fix this would be very appreciated. |
|
|
|
Also I guess |
|
Hi @DanielRuf I think chaining And I think this solution may be less intrusive than stopping the propagation of the event, as the event could still be used by other parts of an application. Probably an important consideration for a library. Please have in mind that this PR is more than three years old, and I am talking from memory here. Don't take my word without running tests yourself ;) |
|
Merging for now but may need some small changes. |
|
@DanielRuf this merge seems to give me an error: If the input is in a label the picker can't be closed, if a container is specified the error still occurs though it will close as expected. |
|
Ah I see. Missed that. I guess it should be |
|
Yeah. That kills the error but doesn't allow an input to work inside a label. |
|
I see the problem actually: |
|
Along with: |
|
Do you want to provide a PR? That would be very helpful. |
relates to:
#40
#265
First of all, thanks for this great plugin.
The two bugs above are caused by a label tag wrapping the input field. They have been flagged as invalid, but as I must disagree, as it is valid and semantic html.