Fix issue causing page to jump when focusing element #594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix ignore pattern
Config option to turn of setting the value of the input.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When scroll to the top of the page, if the date picker is open and rendered partially below the viewport, the browser will jump when closing the date picker. This is easily reproducible in Chrome.
This happens because there is a focus listener on the element that reacts synchronously to the focus event and causes the erratic behavior. I didn't look into exactly why the behavior was what it was.
This is a quick fix. This doesn't happen on the normal version of
pickadate.jsbecause the input is set toreadOnlyand the focus is handled differently. I looked at upgrading to the latestpickadate.jsand getting rid of our fork, but there are a number of differences and the behaviors that we added are still not supported.