Hmm, I was unable to determine what is failing in the Travis CI build. The error message doesn't seem to provide any details and none of the warnings seem relevant to the changes this commit makes.

Related: #522

@amsul, I understand this PR may not be a priority. But I wondered if you could give me some insight into your plans regarding this translation issue so that I can plan how to handle it in my own project.

I can roll these changes into my own project without a problem. But if you have a better or alternative way to deal with this in the future, I'd prefer to follow your lead to reduce compatibility and maintenance issues as pickadate moves forward. In that sense, I'm wondering if the delay is just because of being busy (which is understandable) or if you have plans for the translation that this PR doesn't fit within?

@NateWr, sorry for not being able to respond sooner with this. I appreciate the PR and your candor! This is great, and I'd definitely merge it in. However can u please make one change? Instead of having multiple jQuery.extend blocks in the file, it'd be great if the translations for "clear" would be in the same block..

Ah never mind! I just realized that they're obviously extending different things. I will merge this in soon! Thanks 😄

@amsul, thanks for your response and no worries on the delay!

Is there anything I can do to help you move forward on this and other issues for 3.5.5? My customers are waiting on this and the iOS 8 fix and I'm close to just pushing out the dev branch with an update. However, I'd prefer to help you ship 3.5.5. If there are any adjustments to this PR or additional PR's for other issues you'd like, let me know.

@NateWr, you can take a look at the issues here: https://github.com/amsul/pickadate.js/milestones/3.5.5 :)

If you like, you can point to the master branch (https://github.com/amsul/pickadate.js/tree/master) until a tag release is ready..

Well..merged into master: https://github.com/amsul/pickadate.js :)

Hi there !

I do not know if posting here is the best option but I will give it a try.

I suggest translations for pickadate and pickatime be split. Why? Well I am using pickadate only on some of my pages so jQuery.fn.pickatime.defaults cannot be read (from my console I get this error: "Cannot read property 'defaults' of undefined", undefined being jQuery.fn.pickatime). For example, this is from the French translation file:

jQuery.extend( jQuery.fn.pickatime.defaults, {
    clear: 'Effacer'
});

This is the same if you only use pickatime: jQuery.fn.pickadate.defaults will not be accessible.

You could assign this to me if you are willing to make this update ;) Let me know

Cheers,
Quentin

+1

I just updated to version v3.5.6, 2015/04/20

And I have the same problem. From console of browser I see:

Uncaught TypeError: Cannot read property 'defaults' of undefined

Error with:

jQuery.extend( jQuery.fn.pickatime.defaults, {
    clear: 'borrar'
});