Introduce the datesEnabled API for a more sensible way to enable some dates #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
I was considering this as an option at first.. As elegant as it might seem, it's a bit redundant and confusing since there's 2 options that essentially "disable" certain days and don't disable other days. So which one takes precedence? Or do they both work together? I think it becomes much more obvious when there's only one option for that. Oh, and thanks for the translations and correction! Can you please send the pull request to the "dev" branch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The user shouldn't have to pass some arbitrary "true" to achieve the opposite of the property name.
In my opinion, this is a more elegant way of doing things. Hope you like it!