Added close button functionality #450
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the close button trigger feature...
Added the close button feature.
Added the close button styles...
Add an extra setting "default", in this setting a default date can be parsed into the datepicker using the setting default : new Date(...);
added a extra save button + outerClickSave functionality. If set true the date will be saved when clicked outside the date picker.
See update picker.date.js
Added styles for the save button
Owner
|
Nice, I appreciate the PR! But seems like there’s a lot of changes in there that aren’t relevant to adding a close button (such as If you can reduce this PR to the relevant changes so it’s easier to digest, I can take a look at it again. Cheers! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a close button functionality... However had to convert your code for my project to UTF-8... Thats the reason for the changes in your comment lines :-)