Update picker.date.js #402
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only put YEARS before Month selector if selectMonths is not true.
Owner
|
I think this (#401) misses the point of #384. The confusion lies here: Settings: month and year selectors are shown, min is '2014-06-14', and my month in view is August 2014. First scenario: User wants to go to February 2017. The first dropdown (months) will have Jan-May all disabled. If they understand why it’s disabled, the user has to go to the second dropdown (years) and then come back to the first dropdown. vs Second scenario: User wants to go to February 2017. The first dropdown (years) will be changed to 2017. The second dropdown will be changed to February. It makes the best flow to go from General > Specific. I hope that clears things up! Cheers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only put YEARS before Month selector if selectMonths is not true.