这是indexloc提供的服务,不要输入任何密码
Skip to content

fix: relax transformers dependency #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AzulGarza
Copy link

Issue #, if available:

Description of changes:

this pr relaxes the version constraint for the transformers dependency. i’ve tested the minimal proposed version, and all tests pass successfully.

image

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@lostella
Copy link
Contributor

Thanks @AzulGarza: given this only touches the minimum transformer version, I don’t have concerns.

@abdulfatir do you have any concern?

@abdulfatir
Copy link
Contributor

Thanks @AzulGarza! @lostella I believe we bumped transformers in #280 due to a dependabot security alert. I am not sure how much of a concern that is.

@lostella
Copy link
Contributor

@AzulGarza see the above answer; I think merging this change is not ideal since that will raise again security alerts.

Could you maybe consider taking chronos-forecasting as a dependency, but using no-deps?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants