feat: add comprehensive Git worktree management with follow mode and enhanced UI #452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
🔍 Code Quality ReportThis comment is automatically updated with linting results from CI. Node.js Biome Formatting ✅ Status: PassedNode.js Biome Linting ✅ Status: PassedNode.js Test Coverage ✅ Status: PassedClient Coverage: Server Coverage: Mac Formatting (SwiftFormat) ❌ Status: FailedClick to see detailsMac Linting (SwiftLint) ✅ Status: PassedNode.js TypeScript Type Checking ✅ Status: PassedNode.js Build ✅ Status: PassedNode.js Tests ❌ Status: FailedClick to see detailsNode.js Security Audit ✅ Status: PassediOS Formatting (SwiftFormat) ✅ Status: PassediOS Linting (SwiftLint) ✅ Status: Passed |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
❌ CI FailedFailed Jobs:
|
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
…nd fix shell escaping
| } | ||
| }) | ||
| .catch((error) => { | ||
| clearTimeout(timer); |
There was a problem hiding this comment.
Bug: SocketApiClient Message Handling Vulnerable
The SocketApiClient.sendRequest method has a fundamentally flawed message handling approach. It employs fragile type casting to override the VibeTunnelSocketClient's handleMessage method and to access its MessageBuilder via a complex prototype chain. Additionally, it incorrectly assumes client.send() returns the message content, leading to a faulty if (!message) check. This design relies on unsafe type assertions and incorrect assumptions about the underlying client API, making the request/response flow prone to breakage.
Locations (1)
…gitignore - Remove 427 trace.zip, video.webm, and error-context.md files from web/playwright-videos/ - Add web/playwright-videos/ and related patterns to .gitignore - Add coverage directories to .gitignore to prevent future issues - This should reduce PR size from 65k+ lines back to ~25-30k lines
- Increased timeouts in all helper functions to be 2-3x higher on CI - Updated assertion helpers to wait longer on CI (10s vs 5s) - Updated page objects to have longer timeouts on CI - Configured global playwright timeouts to be higher on CI - This should help reduce timeout failures in CI where resources are more constrained
Collaborator
|
Thanks for the review @steipete! I've addressed your feedback: ✅ Created comprehensive documentation for the tmux/Zellij feature at The remaining linting warnings are about The code-server files mentioned by cursor-bot were not found, so they may have already been removed. |
Collaborator
|
Thanks @steipete! Regarding your inline comment about Regarding the code-server files mentioned by cursor-bot - these files do exist in the codebase:
However, they were not added in this PR. They appear to have been added in a different PR and are already part of the main codebase. The CI is now passing and all the requested changes have been addressed: |
steipete
added a commit
that referenced
this pull request
Aug 1, 2025
- Merge beta.16 content into beta.15 as post-release updates - Update release date from July 31 to August 2, 2025 - Add PR/issue references to all major features and fixes - Add contributors section with new and existing contributors - Include PR #483 (notification fix), #484 (iOS keyboard), #486 (unused import) - Include PR #489 (blinking cursor fix in binary terminal mode) - Reference major feature PRs: #452 (worktree), #475 (notifications), #480 (CJK), #472 (Tailscale), #460 (tmux) Co-Authored-By: Claude <noreply@anthropic.com>
ferg-cod3s
pushed a commit
to ferg-cod3s/tunnelforge
that referenced
this pull request
Sep 23, 2025
ferg-cod3s
pushed a commit
to ferg-cod3s/tunnelforge
that referenced
this pull request
Sep 23, 2025
- Merge beta.16 content into beta.15 as post-release updates - Update release date from July 31 to August 2, 2025 - Add PR/issue references to all major features and fixes - Add contributors section with new and existing contributors - Include PR amantus-ai#483 (notification fix), amantus-ai#484 (iOS keyboard), amantus-ai#486 (unused import) - Include PR amantus-ai#489 (blinking cursor fix in binary terminal mode) - Reference major feature PRs: amantus-ai#452 (worktree), amantus-ai#475 (notifications), amantus-ai#480 (CJK), amantus-ai#472 (Tailscale), amantus-ai#460 (tmux) Co-Authored-By: Claude <noreply@anthropic.com>
ferg-cod3s
pushed a commit
to ferg-cod3s/tunnelforge
that referenced
this pull request
Oct 26, 2025
ferg-cod3s
pushed a commit
to ferg-cod3s/tunnelforge
that referenced
this pull request
Oct 26, 2025
- Merge beta.16 content into beta.15 as post-release updates - Update release date from July 31 to August 2, 2025 - Add PR/issue references to all major features and fixes - Add contributors section with new and existing contributors - Include PR amantus-ai#483 (notification fix), amantus-ai#484 (iOS keyboard), amantus-ai#486 (unused import) - Include PR amantus-ai#489 (blinking cursor fix in binary terminal mode) - Reference major feature PRs: amantus-ai#452 (worktree), amantus-ai#475 (notifications), amantus-ai#480 (CJK), amantus-ai#472 (Tailscale), amantus-ai#460 (tmux) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Git Worktree Support & Major UI/Stability Improvements
This PR introduces comprehensive Git worktree management, keyboard navigation for Mac menubar, and significant stability improvements across the codebase.
🎯 Major Features
Git Worktree Management
/api/git/status,/api/git/branches,/api/worktrees)Keyboard Navigation (Mac)
UI/UX Improvements
[branch]for branch names throughout🐛 Bug Fixes
Stability & Performance
UI Fixes
Test Infrastructure
🔧 Code Quality
Architecture Improvements
session-view.tsinto 7 specialized managerssession-create-forminto smaller componentsGitBranchWorktreeSelectorDeveloper Experience
📋 Technical Details
🧪 Testing
All tests pass with proper memory management. The test suite now includes:
🔄 Migration Notes