Mijia refactoring #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alsuren
reviewed
Sep 21, 2020
| DBUS_METHOD_CALL_TIMEOUT, | ||
| self.session.connection.clone(), | ||
| ); | ||
| temp_humidity.start_notify().await?; |
Owner
There was a problem hiding this comment.
your bluetooth.rs split is such a good idea that I'm suddenly trying to think of ways to move things like this into bluetooth.rs (definitely not in this PR).
ef8b569 to
777a8fa
Compare
777a8fa to
5fec7ad
Compare
alsuren
reviewed
Sep 22, 2020
mijia/src/bluetooth.rs
Outdated
| let k = k.as_str()?.into(); | ||
| let v = v.box_clone(); | ||
| let v = cast::<Vec<u8>>(&v)?.clone(); | ||
| let v = cast::<Variant<Vec<u8>>>(&v)?.0.clone(); |
Owner
There was a problem hiding this comment.
Pre-approved for when you push the change to use into_iter() etc. I really think that the best time to fix it properly is as part of #9 so I'm happy to leave it as-is for now.
If you want to write a test that's realistic, you will probably need to add an extra layer of nesting, so you can't Any your way out of trouble without boxed_clone, (we're currently a hashmap of {sv}, where the v is a Variant of &[u8] or something, so we're already borrowing from the outer hashmap)
alsuren
approved these changes
Sep 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've tried to separate the Mijia-specific code from the general BLE stuff. I've also added a few comments.