Refactor Mijia crate a bit #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alsuren
reviewed
Sep 19, 2020
alsuren
reviewed
Sep 19, 2020
mijia/src/decode.rs
Outdated
| /// Decode the readings from the raw bytes of the Bluetooth characteristic value, if they are | ||
| /// valid. | ||
| /// Returns `None` if the value is not valid. | ||
| pub fn decode(value: &[u8]) -> Option<Readings> { |
Owner
There was a problem hiding this comment.
long-term, I would be tempted to implement https://doc.rust-lang.org/std/convert/trait.TryFrom.html , and then use let readings = value.try_into().ok()? in the one place where it's used.
For now, I don't think that consumers will ever have &[u8] in their hand, so maybe pub(crate) and leave everything else as-is?
Collaborator
Author
There was a problem hiding this comment.
Done the latter.
alsuren
approved these changes
Sep 19, 2020
7e8b344 to
7c12de8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just moving things around and adding a few doc comments.